Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flags and melee nerf in fishing.json #75638

Merged
merged 13 commits into from
Aug 19, 2024

Conversation

Takumonium
Copy link
Contributor

@Takumonium Takumonium commented Aug 13, 2024

Added suitable flags and adjusted melee parameters of each rod and hook.

Summary

Balance "Fishing hooks and rods melee parameters nerf"

Purpose of change

Dukepauladreites#0000 Suggested to add BELT_CLIP tag onto one the collapsible fishing rod that has 50cm of length which is short enough to be clipped upon existing tool belts as tools of similar length.

Missing flags and questionable melee parameters in same JSON file.

Describe the solution

Simple JSON edit

Describe alternatives you've considered

Doing it later
Waiting for someone to do the same

Testing

Additional context

As above mentioned reason, Added BELT_CLIP to 50cm collapsed rod.
Added FRAGILE_MELEE to extended rods and makeshift wooden one including both hooks as any wrong move can either heavily dent or completely shatter them irl situation.
Added FIREWOOD to rods made out of wood as it's an obviously burnable material that makes up nearly entirety of said tool.
Added SHEATH_SPEAR to extended rods with a length of around 200cm.
Added REACH_ATTACK to rods with same length as weapons that possess reach attacks, specifically extended rods with around 200cm in length.
Reduced bash stat of extended rods by 2 but added 1 cut dmg as extended rods have less blunt impact when extended but gain a small ability to cut at certain angles.
Reduced to_hit bonus on hooks as they are hard to wield and hit things with.
Reduced hooks' cut dmg by one but add 1 pierce dmg as that's what they do if one were to use it as a weapon for some reason.
Left a comment in one of the rod's code under unidentified function, to be removed it if does nothing or is trivial.

Edit: hooks are no longer usable as a weapon, all legacy to_hit were updated, comment removed.

Added suitable flags and adjusted melee parameters of each rod and hook.
Copy link
Contributor

You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON new contributor Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions labels Aug 13, 2024
@Karol1223
Copy link
Contributor

Karol1223 commented Aug 13, 2024

You are adding to-hit variants using outdated syntax, the tests won't let this PR get merged. If you wanna make this mergeable, don't do anything to make hooks weapons, just remove their damage values. They're way too small to be simulatable anyway.

data/json/items/tool/fishing.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 13, 2024
@github-actions github-actions bot added Code: Tests Measurement, self-control, statistics, balancing. and removed json-styled JSON lint passed, label assigned by github actions labels Aug 15, 2024
Reducing floating numbers as github bot suggests

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 16, 2024
@Maddremor
Copy link
Contributor

I'm very skeptical about using them as weapons at all. If the hook catches you can no longer use the rod as a weapon, and I'm not sure any meaningful force will be transmitted by the long flexing rod if at full length.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 17, 2024
@Maleclypse Maleclypse merged commit 8d3cb96 into CleverRaven:master Aug 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants